Re: [PATCH net-next 09/11] bnxt_en: update all firmware calls to use the new APIs

Hi Michael,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8
config: i386-randconfig-a002-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0202eb069086d82c68032e9f5db76e0b4cd5a4ca
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031
        git checkout 0202eb069086d82c68032e9f5db76e0b4cd5a4ca
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument]
   In file included from drivers/net/ethernet/broadcom/bnxt/bnxt.c:11:
   In file included from include/linux/module.h:14:
   In file included from include/linux/buildid.h:5:
   In file included from include/linux/mm_types.h:9:
   In file included from include/linux/spinlock.h:51:
   In file included from include/linux/preempt.h:78:
   In file included from arch/x86/include/asm/preempt.h:7:
   In file included from include/linux/thread_info.h:60:
   arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
           oldframe = __builtin_frame_address(1);
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
                   frame = __builtin_frame_address(2);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/net/ethernet/broadcom/bnxt/bnxt.c:5996:2: warning: variable 'req' is uninitialized when used here [-Wuninitialized]

           req->fid = cpu_to_le16(fid);
           ^~~
   drivers/net/ethernet/broadcom/bnxt/bnxt.c:5990:34: note: initialize the variable 'req' to silence this warning
           struct hwrm_func_qcfg_input *req;
                                           ^
                                            = NULL
   3 warnings generated.
--
   clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument]
   In file included from drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:11:
   In file included from include/linux/ethtool.h:17:
   In file included from include/linux/compat.h:14:
   In file included from include/linux/sem.h:5:
   In file included from include/uapi/linux/sem.h:5:
   In file included from include/linux/ipc.h:5:
   In file included from include/linux/spinlock.h:51:
   In file included from include/linux/preempt.h:78:
   In file included from arch/x86/include/asm/preempt.h:7:
   In file included from include/linux/thread_info.h:60:
   arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
           oldframe = __builtin_frame_address(1);
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
                   frame = __builtin_frame_address(2);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:7: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

                   if (is_valid_ether_addr(bp->vf.mac_addr))
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1178:6: note: uninitialized use occurs here
           if (rc && strict) {
               ^~
   drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:3: note: remove the 'if' if its condition is always true
                   if (is_valid_ether_addr(bp->vf.mac_addr))
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1157:8: note: initialize the variable 'rc' to silence this warning
           int rc;
                 ^
                  = 0
   3 warnings generated.


vim +/req +5996 drivers/net/ethernet/broadcom/bnxt/bnxt.c

  5986	
  5987	int __bnxt_hwrm_get_tx_rings(struct bnxt *bp, u16 fid, int *tx_rings)
  5988	{
  5989		struct hwrm_func_qcfg_output *resp;
  5990		struct hwrm_func_qcfg_input *req;
  5991		int rc;
  5992	
  5993		if (bp->hwrm_spec_code < 0x10601)
  5994			return 0;
  5995	

5996		req->fid = cpu_to_le16(fid);

  5997		resp = hwrm_req_hold(bp, req);
  5998		rc = hwrm_req_send(bp, req);
  5999		if (!rc)
  6000			*tx_rings = le16_to_cpu(resp->alloc_tx_rings);
  6001	
  6002		hwrm_req_drop(bp, req);
  6003		return rc;
  6004	}
  6005	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org