Thread (5 messages) flat view 5 messages, 3 authors, 2021-08-27

Re: [PATCH net] net: dsa: mv88e6xxx: stop calling irq_domain_add_simple with the reg_lock held

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-08-27 20:14:02

On Fri, Aug 27, 2021 at 10:04:14PM +0200, Andrew Lunn wrote:
quoted
Ok, retarget to "net-next"?
I would prefer to wait until you have finished your testing and have
something which builds upon it. If its not broken, don't fix it...
So I'm not actually sure why lockdep only catches it when I move that
code around. Anyways, there might not be anything that builds upon it,
but I see the change as an improvement to the consistency of the locking
order anyway, regardless of whether an automated validator catches it or
not? I mean, extrapolating a bit, would you take rtnl_lock while you
already hold reg_lock, even if only at probe time where there is no
practical possibility to deadlock since the rtnl_lock would have nothing
to do with mv88e6xxx netdevs?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help