Re: [PATCH net-next v3 2/3] bnxt: count packets discarded because of netpoll
From: Michael Chan <michael.chan@broadcom.com>
Date: 2021-08-26 18:44:12
On Thu, Aug 26, 2021 at 6:12 AM Jakub Kicinski [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -10646,11 +10653,15 @@ static void bnxt_get_ring_stats(struct bnxt *bp, stats->multicast += BNXT_GET_RING_STATS64(sw, rx_mcast_pkts); stats->tx_dropped += BNXT_GET_RING_STATS64(sw, tx_error_pkts); + + bsw_stats->rx.rx_netpoll_discards += + cpr->sw_stats.rx.rx_netpoll_discards;
Can we just add these rx_netpoll_discards counters directly to stats->rx_dropped? It looks simpler if we do it that way, right?
}
}
static void bnxt_add_prev_stats(struct bnxt *bp,
- struct rtnl_link_stats64 *stats)
+ struct rtnl_link_stats64 *stats,
+ struct bnxt_sw_stats *bsw_stats)
{
struct rtnl_link_stats64 *prev_stats = &bp->net_stats_prev;Attachments
- smime.p7s [application/pkcs7-signature] 4209 bytes