Thread (2 messages) 2 messages, 2 authors, 2021-08-26

Re: [PATCH] qed: Enable RDMA relaxed ordering

From: Shai Malin <hidden>
Date: 2021-08-26 12:05:27
Also in: linux-rdma

On Mon, Aug 23, 2021 at 02:52:21PM +0300, Leon Romanovsky wrote:
+RDMA

Jakub, David

Can we please ask that everything directly or indirectly related to RDMA
will be sent to linux-rdma@ too?
In addition to all that was discussed regarding qed_rdma.c 
and qed_rdma_ops - certainly, everything directly or indirectly 
related to RDMA will be sent to linux-rdma.
On Sun, Aug 22, 2021 at 09:54:48PM +0300, Shai Malin wrote:
quoted
Enable the RoCE and iWARP FW relaxed ordering.

Signed-off-by: Ariel Elior <redacted>
Signed-off-by: Shai Malin <redacted>
---
 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
quoted
index 4f4b79250a2b..496092655f26 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -643,6 +643,8 @@ static int qed_rdma_start_fw(struct qed_hwfn
*p_hwfn,
quoted
 				    cnq_id);
 	}

+	p_params_header->relaxed_ordering = 1;
Maybe it is only description that needs to be updated, but I would
expect to see call to pcie_relaxed_ordering_enabled() before setting
relaxed_ordering to always true.
This change will only allow the FW to support relaxed ordering but it 
will be enabled only if the device/root-complex/server supports 
relaxed ordering.
The pcie_relaxed_ordering_enabled() is not needed in this case.
If we are talking about RDMA, the IB_ACCESS_RELAXED_ORDERING flag should
be taken into account too.
Thanks! 
We will need to add both FW and driver support to enable it.
Thanks
quoted
+
 	return qed_spq_post(p_hwfn, p_ent, NULL);
 }

--
2.22.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help