Re: [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors

On Thu, 26 Aug 2021 03:42:08 +0300 Vladimir Oltean wrote:

On Wed, Aug 25, 2021 at 05:35:37PM -0700, Jakub Kicinski wrote:

quoted

On Thu, 26 Aug 2021 03:22:57 +0300 Vladimir Oltean wrote:  

quoted

'Could you consider adding "driver" stats under RTM_GETSTATS,
or a similar new structured interface over ethtool?

Looks like the statistic in question has pretty clear semantics,
and may be more broadly useful.'  

It's commonly reported per ring, I need for make a home for these
first by adding that damn netlink queue API. It's my next project.

I can drop the ethtool stat from this patch if you have a strong
preference.  

I don't have any strong preference, far from it. What would you do if
you were reviewing somebody else's patch which made the same change?

If someone else posted this patch I'd probably not complain, as I said
there is no well suited API, and my knee jerk expectation was it should
be reported in the per-queue API which doesn't exist.

When you'd seem me complain is when drivers expose in -S stats which
have proper APIs or when higher layer/common code is trying to piggy
back on -S instead of creating its own structured interface.

I don't see value in tracking this particular statistic in production
settings, maybe that's also affecting my judgment here. But since
that's the case I'll just drop it.


If you have any feedback on my suggestions, reviews, comments etc.
please do share on- or off-list at any time. No need to wait a year
until I post a vaguely similar patch ;)