Thread (6 messages) flat view 6 messages, 3 authors, 2021-08-26

Re: [PATCH net 2/2] net: dsa: hellcreek: Adjust schedule look ahead window

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-08-25 16:34:40


On 8/25/2021 3:58 PM, Kurt Kanzenbach wrote:
Traffic schedules can only be started up to eight seconds within the
future. Therefore, the driver periodically checks every two seconds whether the
admin base time provided by the user is inside that window. If so the schedule
is started. Otherwise the check is deferred.
Uber nit: this probably ought to be just one sentence starting from 
"Therefore" and ending at deferred.
However, according to the programming manual the look ahead window size should
be four - not eight - seconds. By using the proposed value of four seconds
starting a schedule at a specified admin base time actually works as expected.

Fixes: 24dfc6eb39b2 ("net: dsa: hellcreek: Add TAPRIO offloading support")
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help