Re: [RFC PATCH net-next v3 1/6] ethtool: Add ability to control transceiver modules' power mode

On Tue, 24 Aug 2021 23:18:56 +0000 Keller, Jacob E wrote:

quoted

quoted

+ * @mode_valid: Indicates the validity of the @mode field. Should be set by
+ * device drivers on get operations when a module is plugged-in.  

Should we make a firm decision on whether we want to use these kind of
valid bits or choose invalid defaults? As you may guess my preference
is the latter since that's what I usually do, that way drivers don't
have to write two fields.

Actually I think this may be the first "valid" in ethtool, I thought we
already had one but I don't see it now..

coalesce settings have a valid mode don't they? Or at least an "accepted modes"?

That's a static per-driver bitmask 'cause we don't trust driver writers
to error out on all the unsupported fields. The driver code doesn't
operate on it in the callbacks.