Re: [PATCH v3 net-next 3/7] net: switchdev: move SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE to the blocking notifier chain
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-08-20 16:55:16
Also in:
linux-s390
On Fri, 20 Aug 2021 18:57:49 +0300 Vladimir Oltean wrote:
On Fri, Aug 20, 2021 at 08:54:02AM -0700, Jakub Kicinski wrote:quoted
On Fri, 20 Aug 2021 14:57:42 +0300 Vladimir Oltean wrote:quoted
Currently, br_switchdev_fdb_notify() uses call_switchdev_notifiers (and br_fdb_replay() open-codes the same thing). This means that drivers handle the SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE events on the atomic switchdev notifier block.drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c: In function ‘sparx5_switchdev_fdb_event’: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c:453:1: warning: label ‘err_addr_alloc’ defined but not used [-Wunused-label] 453 | err_addr_alloc: | ^~~~~~~~~~~~~~Yeah, I noticed (too late sadly). Other than a bit of dead code it does not impact functionality, so that's why I didn't jump to resend until I got some feedback first (thanks Vlad). Do you think it's time to resend?
No really, I just don't want to drop things from patchwork without making a note of what the reason was. You can reply to your own posting saying that you noticed an error but want it reviewed anyway, or wait for me to complain and quietly stick to your plan.. No real preference.