Re: [PATCH net-next 2/2] net: Fix offloading indirect devices dependency on qdisc order creation

On Tue, 17 Aug 2021 17:30:09 +0300 Eli Cohen wrote:

On Tue, Aug 17, 2021 at 07:00:41AM -0700, Jakub Kicinski wrote:

quoted

On Tue, 17 Aug 2021 16:22:17 +0300 Eli Cohen wrote:  

quoted

Currently, when creating an ingress qdisc on an indirect device before
the driver registered for callbacks, the driver will not have a chance
to register its filter configuration callbacks.

To fix that, modify the code such that it keeps track of all the ingress
qdiscs that call flow_indr_dev_setup_offload(). When a driver calls
flow_indr_dev_register(),  go through the list of tracked ingress qdiscs
and call the driver callback entry point so as to give it a chance to
register its callback.

Reviewed-by: Jiri Pirko <redacted>
Signed-off-by: Eli Cohen <redacted>  

net/core/flow_offload.c: In function ‘existing_qdiscs_register’:
net/core/flow_offload.c:365:20: warning: variable ‘block’ set but not used [-Wunused-but-set-variable]
  365 |  struct tcf_block *block;
      |                    ^~~~~  

Thanks Jakub.
Would you mind telling me how you invoked the compiler to catch this?

make W=1