On Sat, 2021-08-14 at 09:22 -0700, Stephen Hemminger wrote:
On Sat, 14 Aug 2021 15:24:38 +0530
Gokul Sivakumar [off-list ref] wrote:
quoted
+ if (!filter_index && r->ndm_ifindex) {
+ if (!is_json_context())
+ fprintf(fp, "dev ");
This looks functionally correct, but please use:
print_string(PRINT_FP, NULL, "dev ", NULL);
The reason as part of the json conversions I look for fprintf(fp
as indicator of unconverted code.
Ok, thanks for the review. I will send an updated v2 patchset now
with the 2 newly added fprintf() calls replaced by print_string().