Re: [PATCH iproute2] lib: bpf_glue: remove useless assignment
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-08-11 16:08:24
On Wed, 11 Aug 2021 11:12:43 +0200 Andrea Claudi [off-list ref] wrote:
On Tue, Aug 10, 2021 at 08:00:48PM -0700, Stephen Hemminger wrote:quoted
On Sat, 7 Aug 2021 18:58:02 +0200 Andrea Claudi [off-list ref] wrote:quoted
- while ((s = fgets(buf, sizeof(buf), fp)) != NULL) { + while (fgets(buf, sizeof(buf), fp) != NULL) { if ((s = strstr(buf, "libbpf.so.")) != NULL) {Ok. but it would be good to get rid of the unnecessary assignment in conditional as well.Hi Stephen, That's not unnecessary, s is used as the second parameter in the following strncpy().
It is bad style in C to do assignment in a conditional. It causes errors, and is not anymore efficient.