Thread (17 messages) flat view 17 messages, 4 authors, 2021-08-11

Re: [RFC PATCH net-next 3/4] net: dsa: create a helper for locating EtherType DSA headers on RX

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-08-10 01:05:30

On Mon, Aug 09, 2021 at 02:57:21PM +0300, Vladimir Oltean wrote:
It seems that protocol tagging driver writers are always surprised about
the formula they use to reach their EtherType header on RX, which
becomes apparent from the fact that there are comments in multiple
drivers that mention the same information.

Create a helper that returns a void pointer to skb->data - 2, as well as
centralize the explanation why that is the case.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help