[RFC PATCH net-next 0/3] txhash: Make hash rethink configurable and change the default
From: Tom Herbert <hidden>
Date: 2021-08-09 18:53:56
Alexander Azimov performed some nice analysis of the feature in Linux stack where the IPv6 flow label is changed when the stack detects a connection is failing. The idea of the algorithm is to try to find a better path. His reults are quite impressive, and show that this form of source routing can work effectively. Alex raised an issue in that if the server endpoint is an IP anycast address, the connection might break if the flow label changes routing of packets on the connection. Anycast is known to be susceptible to route changes, not just those caused be flow label. The concern is that flow label modulation might increases the chances that anycast connections might break, especially if the rethink occurs after just one RTO which is the current behavior. This patch set makes the rethink behavior granular and configurable. It allows control of when to do the hash rethink: upon negative advice, at RTO in SYN state, at RTO when not in SYN state. The behavior can be configured by sysctl and by a socket option. This patch set the defautl rethink behavior to be to do a rethink only on negative advice. This is reverts back to the original behavior of the hash rethink mechanism. This less aggressive with the intent of mitigating potentail breakages when anycast addresses are present. For those users that are benefitting from changing the hash at the first RTO, they would retain that behavior by setting the sysctl. *** BLURB HERE *** Tom Herbert (3): txhash: Make rethinking txhash behavior configurable via sysctl txhash: Add socket option to control TX hash rethink behavior txhash: Change default rethink behavior to be less aggressive arch/alpha/include/uapi/asm/socket.h | 2 ++ arch/mips/include/uapi/asm/socket.h | 2 ++ arch/parisc/include/uapi/asm/socket.h | 2 ++ arch/sparc/include/uapi/asm/socket.h | 3 ++- include/net/netns/core.h | 2 ++ include/net/sock.h | 32 +++++++++++++++++++-------- include/uapi/asm-generic/socket.h | 2 ++ include/uapi/linux/socket.h | 13 +++++++++++ net/core/net_namespace.c | 4 ++++ net/core/sock.c | 16 ++++++++++++++ net/core/sysctl_net_core.c | 7 ++++++ net/ipv4/tcp_input.c | 2 +- net/ipv4/tcp_timer.c | 5 ++++- 13 files changed, 80 insertions(+), 12 deletions(-) -- 2.25.1