Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock

On Wed, Aug 4, 2021 at 5:29 PM Jakub Kicinski [off-list ref] wrote:

On Wed, 4 Aug 2021 16:26:31 +0300 Or Gerlitz wrote:

quoted

On Fri, Jul 23, 2021 at 9:09 AM Christoph Hellwig [off-list ref] wrote:

quoted

On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote:

quoted

From: Boris Pismenny <redacted>

get_netdev_for_sock is a utility that is used to obtain
the net_device structure from a connected socket.

Later patches will use this for nvme-tcp DDP and DDP DDGST offloads.

Signed-off-by: Boris Pismenny <redacted>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

I don't think this should be an inline.  Please move it to net/core/dev.c,
andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment.

Jakub,

What's your preference here?

Fine either way.

copying the list and few ppl