Thread (14 messages) flat view 14 messages, 5 authors, 2021-08-04

Re: [PATCH net-next] Revert "netdevsim: Add multi-queue support"

From: Cong Wang <hidden>
Date: 2021-08-03 17:11:38

On Tue, Aug 3, 2021 at 5:39 AM Jakub Kicinski [off-list ref] wrote:
This reverts commit d4861fc6be581561d6964700110a4dede54da6a6.

netdevsim is for enabling upstream tests, two weeks in
and there's no sign of upstream test using the "mutli-queue"
option.
Since when netdevsim is *only* for upstream tests? Even if so,
where is this documented? And why not just point it out when
reviewing it instead of silently waiting for weeks?
We can add this option back when such test materializes.
Right now it's dead code.
It is clearly not dead. We internally used it for testing sch_mq,
this is clearly stated in the git log. How did you draw such a
conclusion without talking to authors?

But this does remind me of using netdevsim for tc-testing.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help