Re: [PATCH net 1/2] net: usb: pegasus: Check the return value of get_geristers() and friends;

On 21-08-03 18:46:36, Pavel Skripkin wrote:

On 8/3/21 6:45 PM, Petko Manolov wrote:

quoted

On 21-08-03 18:28:55, Pavel Skripkin wrote:

quoted

On 8/3/21 6:03 PM, Petko Manolov wrote:

quoted

From: Petko Manolov <petkan@nucleusys.com>

quoted

Certain call sites of get_geristers() did not do proper error

handling.  This

quoted

could be a problem as get_geristers() typically return the data via pointer to a
buffer.  If an error occured the code is carelessly manipulating the wrong data.

quoted

Signed-off-by: Petko Manolov <petkan@nucleusys.com>

Hi, Petko!

This patch looks good to me, but I found few small mistakes

Yeah, the patch was never compiled.  Sorry about it.  v2 is coming up.

BTW: should this also go to stable with Fixes: 1da177e4c3f4
("Linux-2.6.12-rc2")?

Yeah, i think so.  Apparently the issues this patch fixes have not manifested
themselves very frequently.  Either that or nobody is using this driver now. :)

Anyway, the bugs are real and fixes going to the stable series is well
justified.  Thanks a bunch for the review.


cheers,
Petko