Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-08-02 19:00:55
On 02.08.2021 18:54, Jakub Kicinski wrote:
On Mon, 2 Aug 2021 18:42:28 +0200 Heiner Kallweit wrote:quoted
On 02.08.2021 16:15, Jakub Kicinski wrote:quoted
On Sun, 1 Aug 2021 18:25:52 +0200 Heiner Kallweit wrote:quoted
Patchwork is showing the following warning for all patches in the series. netdev/cc_maintainers warning 7 maintainers not CCed: ecree@solarflare.com andrew@lunn.ch magnus.karlsson@intel.com danieller@nvidia.com arnd@arndb.de irusskikh@marvell.com alexanderduyck@fb.com This seems to be a false positive, e.g. address ecree@solarflare.com doesn't exist at all in MAINTAINERS file.It gets the list from the get_maintainers script. It's one of the less reliable tests, but I feel like efforts should be made primarily towards improving get_maintainers rather than improving the test itself.When running get_maintainers.pl for any of the patches in the series I don't get these addresses. I run get_maintainers w/o options, maybe you set some special option? That's what I get when running get_maintainers: "David S. Miller" [off-list ref] (maintainer:NETWORKING [GENERAL]) Jakub Kicinski [off-list ref] (maintainer:NETWORKING [GENERAL]) Stephen Rothwell [off-list ref] (commit_signer:1/2=50%,authored:1/2=50%,added_lines:3144/3159=100%) Heiner Kallweit [off-list ref] (commit_signer:1/2=50%,authored:1/2=50%,removed_lines:3/3=100%) netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) linux-kernel@vger.kernel.org (open list)Mm. Maybe your system doesn't have some perl module? Not sure what it may be. With tip of net-next/master: $ ./scripts/get_maintainer.pl /tmp/te/0002-ethtool-move-implementation-of-ethnl_ops_begin-compl.patch "David S. Miller" [off-list ref] (maintainer:NETWORKING [GENERAL],commit_signer:12/16=75%,commit_signer:15/18=83%) Jakub Kicinski [off-list ref] (maintainer:NETWORKING [GENERAL],commit_signer:11/16=69%,authored:9/16=56%,added_lines:127/198=64%,removed_lines:41/57=72%,commit_signer:14/18=78%,authored:11/18=61%,added_lines:74/84=88%,removed_lines:35/52=67%) Heiner Kallweit [off-list ref] (commit_signer:3/16=19%,authored:3/16=19%,added_lines:46/198=23%,removed_lines:13/57=23%,authored:1/18=6%,removed_lines:13/52=25%) Fernando Fernandez Mancera [off-list ref] (commit_signer:1/16=6%,authored:1/16=6%) Vladyslav Tarasiuk [off-list ref] (commit_signer:1/16=6%,added_lines:11/198=6%,commit_signer:1/18=6%) Yangbo Lu [off-list ref] (authored:1/16=6%,added_lines:10/198=5%,authored:1/18=6%) Johannes Berg [off-list ref] (authored:1/16=6%) Zheng Yongjun [off-list ref] (commit_signer:1/18=6%) Andrew Lunn [off-list ref] (commit_signer:1/18=6%) Danielle Ratson [off-list ref] (authored:1/18=6%) Ido Schimmel [off-list ref] (authored:1/18=6%) netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) linux-kernel@vger.kernel.org (open list)
Ah, maybe it's because I typically don't work with the full git repo but just do a "git clone --depth 1".