Thread (1 message) flat view 1 message, 1 author, 2021-07-24

Re: [PATCH v4 03/10] net/ps3_gelic: Format cleanups

From: Christophe Leroy <hidden>
Date: 2021-07-24 15:39:33
Also in: linuxppc-dev

Geoff Levand [off-list ref] a écrit :
In an effort to make the PS3 gelic driver easier to maintain, cleanup the
the driver source file formatting to be more consistent.
Many of your changes in this patch go in the wrong direction.

For instance, you shall not use { } in an if/else sequence with single  
lines in both the if and the else. See  
https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces

In a multiline operation, the argument of the second line must be  
aligned to the matching parenthesis.

Christophe

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help