Thread (2 messages) flat view 2 messages, 2 authors, 2021-07-17

Re: [PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures

From: Geoff Levand <geoff@infradead.org>
Date: 2021-07-17 22:37:22
Also in: linuxppc-dev

Hi Christophe,

On 7/11/21 7:03 AM, Christophe Leroy wrote:
Your patch has a lot of cosmetic changes. Several of them are just wrong. The other ones belong to another patch. This patch should focus only on the changes it targets.

Your patch is way too big and addresses several different topics. Should be split in several patches.

I suggest you run checkpatch.pl --strict on your patch
Thanks for the review.  I'll create a follow up patch set with
your comments in mind.

-Geoff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help