Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode
From: Yonghong Song <hidden>
Date: 2021-07-27 16:43:44
Also in:
bpf
On 7/27/21 6:17 AM, Magnus Karlsson wrote:
From: Magnus Karlsson <magnus.karlsson@intel.com> Remove color mode.
Could you add some reasoning in the commit message why removing color mode is a good idea?
quoted hunk ↗ jump to hunk
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> --- tools/testing/selftests/bpf/test_xsk.sh | 10 +++----- tools/testing/selftests/bpf/xsk_prereqs.sh | 27 +++++----------------- 2 files changed, 9 insertions(+), 28 deletions(-)diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh index 46633a3bfb0b..cd7bf32e6a17 100755 --- a/tools/testing/selftests/bpf/test_xsk.sh +++ b/tools/testing/selftests/bpf/test_xsk.sh@@ -63,14 +63,11 @@ # ---------------- # Must run with CAP_NET_ADMIN capability. # -# Run (full color-coded output): -# sudo ./test_xsk.sh -c +# Run: +# sudo ./test_xsk.sh # # If running from kselftests: -# sudo make colorconsole=1 run_tests -# -# Run (full output without color-coding): -# sudo ./test_xsk.sh +# sudo make run_tests
[...]