Thread (6 messages) 6 messages, 3 authors, 2021-07-27

Re: [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument

From: Yonghong Song <hidden>
Date: 2021-07-26 02:34:42
Also in: bpf


On 7/24/21 8:21 AM, Juhee Kang wrote:
The current behavior of 'tracex7' doesn't consist with other bpf samples
tracex{1..6}. Other samples do not require any argument to run with, but
tracex7 should be run with btrfs device argument. (it should be executed
with test_override_return.sh)

Currently, tracex7 doesn't have any description about how to run this
program and raises an unexpected error. And this result might be
confusing since users might not have a hunch about how to run this
program.

     // Current behavior
     # ./tracex7
     sh: 1: Syntax error: word unexpected (expecting ")")
     // Fixed behavior
     # ./tracex7
     ERROR: Run with the btrfs device argument!

In order to fix this error, this commit adds logic to report a message
and exit when running this program with a missing argument.

Additionally in test_override_return.sh, there is a problem with
multiple directory(tmpmnt) creation. So in this commit adds a line with
removing the directory with every execution.

Signed-off-by: Juhee Kang <redacted>
Acked-by: Yonghong Song <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help