Re: [PATCH 36/64] scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2021-07-29 03:40:25
Also in:
dri-devel, linux-block, linux-hardening, linux-kbuild, linux-staging, linux-wireless, lkml
Kees,
For example, change it to: + BUILD_BUG_ON(sizeof(evt_struct->iu.srp) != SRP_MAX_IU_LEN); + memset(&evt_struct->iu.srp, 0x00, sizeof(evt_struct->iu.srp)); srp_cmd = &evt_struct->iu.srp.cmd; - memset(srp_cmd, 0x00, SRP_MAX_IU_LEN);
For the moment, I'll leave the patch as-is unless you prefer having the BUILD_BUG_ON(). :)
I'm OK with the BUILD_BUG_ON(). Hopefully Tyrel or Brian will chime in. -- Martin K. Petersen Oracle Linux Engineering