Re: [PATCH 2/3] arm: include: asm: unified: mask .syntax unified for clang
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2021-07-27 17:55:44
Also in:
bpf, linux-arm-kernel, lkml
On Tue, Jul 27, 2021 at 7:12 AM Pavo Banicevic [off-list ref] wrote:
From: Ivan Khoronzhuk <redacted> The samples/bpf reuses linux headers, with clang -emit-llvm, so this w/a is only for samples/bpf (samples/bpf/Makefile CLANG-bpf). It allows to build samples/bpf for arm on target board. In another way clang -emit-llvm generates errors like: <inline asm>:1:1: error: unknown directive .syntax unified I have verified it on clang 5, 6, 7, 8, 9, 10 as on native platform as for cross-compiling. This decision is arguable, but it doesn't have impact on samples/bpf so it's easier just ignore it for clang, at least for now...
Did you test ARCH=arm kernel builds with Clang with this series applied?
quoted hunk ↗ jump to hunk
Signed-off-by: Ivan Khoronzhuk <redacted> --- arch/arm/include/asm/unified.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/arch/arm/include/asm/unified.h b/arch/arm/include/asm/unified.h index 1e2c3eb04353..8718f313e7c4 100644 --- a/arch/arm/include/asm/unified.h +++ b/arch/arm/include/asm/unified.h@@ -11,7 +11,9 @@ #if defined(__ASSEMBLY__) .syntax unified #else -__asm__(".syntax unified"); + +#ifndef __clang__ + __asm__(".syntax unified"); #endif #ifdef CONFIG_CPU_V7M --2.32.0
-- Thanks, ~Nick Desaulniers