This patchset is fixing compilation issues that are encountered in our usage of the Linux kernel.
Two patches are addressing compilation of eBPF related software with clang compiler on arm architecture.
The third patch resolves compilation of the perf tool in this specific scenario.
We are also interested in possible alternative approaches in fixing these compilation issues which could
then be incorporated into the mainline.
Ivan Khoronzhuk (2):
arm: include: asm: swab: mask rev16 instruction for clang
arm: include: asm: unified: mask .syntax unified for clang
Matt Redfearn (1):
include/uapi/linux/swab: Fix potentially missing __always_inline
arch/arm/include/asm/swab.h | 3 +++
arch/arm/include/asm/unified.h | 4 +++-
include/uapi/linux/swab.h | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
--
2.32.0
From: Ivan Khoronzhuk <redacted>
The samples/bpf with clang -emit-llvm reuses linux headers to build
bpf samples, and this w/a only for samples (samples/bpf/Makefile
CLANG-bpf).
It allows to build samples/bpf for arm bpf using clang.
In another way clang -emit-llvm generates errors like:
CLANG-bpf samples/bpf/tc_l2_redirect_kern.o
<inline asm>:1:2: error: invalid register/token name
rev16 r3, r0
This decision is arguable, probably there is another way, but
it doesn't have impact on samples/bpf, so it's easier just ignore
it for clang, at least for now.
Signed-off-by: Ivan Khoronzhuk <redacted>
---
arch/arm/include/asm/swab.h | 3 +++
1 file changed, 3 insertions(+)
From: Ivan Khoronzhuk <redacted>
The samples/bpf reuses linux headers, with clang -emit-llvm,
so this w/a is only for samples/bpf (samples/bpf/Makefile CLANG-bpf).
It allows to build samples/bpf for arm on target board.
In another way clang -emit-llvm generates errors like:
<inline asm>:1:1: error: unknown directive
.syntax unified
I have verified it on clang 5, 6, 7, 8, 9, 10
as on native platform as for cross-compiling. This decision is
arguable, but it doesn't have impact on samples/bpf so it's easier
just ignore it for clang, at least for now...
Signed-off-by: Ivan Khoronzhuk <redacted>
---
arch/arm/include/asm/unified.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
From: Matt Redfearn <redacted>
Commit bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining
of some byteswap operations") added __always_inline to swab functions
and commit 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to
userspace headers") added a definition of __always_inline for use in
exported headers when the kernel's compiler.h is not available.
However, since swab.h does not include stddef.h, if the header soup does
not indirectly include it, the definition of __always_inline is missing,
resulting in a compilation failure, which was observed compiling the
perf tool using exported headers containing this commit:
In file included from /usr/include/linux/byteorder/little_endian.h:12:0,
from /usr/include/asm/byteorder.h:14,
from tools/include/uapi/linux/perf_event.h:20,
from perf.h:8,
from builtin-bench.c:18:
/usr/include/linux/swab.h:160:8: error: unknown type name `__always_inline'
static __always_inline __u16 __swab16p(const __u16 *p)
Fix this by replacing the inclusion of linux/compiler.h with
linux/stddef.h to ensure that we pick up that definition if required,
without relying on it's indirect inclusion. compiler.h is then included
indirectly, via stddef.h.
Fixes: 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to userspace headers")
Signed-off-by: Matt Redfearn <redacted>
---
include/uapi/linux/swab.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Yonghong Song <hidden> Date: 2021-07-27 15:47:13
On 7/27/21 7:11 AM, Pavo Banicevic wrote:
quoted hunk
From: Ivan Khoronzhuk <redacted>
The samples/bpf with clang -emit-llvm reuses linux headers to build
bpf samples, and this w/a only for samples (samples/bpf/Makefile
CLANG-bpf).
It allows to build samples/bpf for arm bpf using clang.
In another way clang -emit-llvm generates errors like:
CLANG-bpf samples/bpf/tc_l2_redirect_kern.o
<inline asm>:1:2: error: invalid register/token name
rev16 r3, r0
This decision is arguable, probably there is another way, but
it doesn't have impact on samples/bpf, so it's easier just ignore
it for clang, at least for now.
Signed-off-by: Ivan Khoronzhuk <redacted>
---
arch/arm/include/asm/swab.h | 3 +++
1 file changed, 3 insertions(+)
From: Nick Desaulniers <ndesaulniers@google.com> Date: 2021-07-27 17:53:39
On Tue, Jul 27, 2021 at 7:12 AM Pavo Banicevic
[off-list ref] wrote:
From: Ivan Khoronzhuk <redacted>
The samples/bpf with clang -emit-llvm reuses linux headers to build
bpf samples, and this w/a only for samples (samples/bpf/Makefile
CLANG-bpf).
It allows to build samples/bpf for arm bpf using clang.
In another way clang -emit-llvm generates errors like:
CLANG-bpf samples/bpf/tc_l2_redirect_kern.o
<inline asm>:1:2: error: invalid register/token name
rev16 r3, r0
This decision is arguable, probably there is another way, but
it doesn't have impact on samples/bpf, so it's easier just ignore
it for clang, at least for now.
NACK
The way to fix these is to sort out the header includes, not turning
off arbitrary things that are used by the actual kernel build for 32b
ARM.
From: Nick Desaulniers <ndesaulniers@google.com> Date: 2021-07-27 17:55:44
On Tue, Jul 27, 2021 at 7:12 AM Pavo Banicevic
[off-list ref] wrote:
From: Ivan Khoronzhuk <redacted>
The samples/bpf reuses linux headers, with clang -emit-llvm,
so this w/a is only for samples/bpf (samples/bpf/Makefile CLANG-bpf).
It allows to build samples/bpf for arm on target board.
In another way clang -emit-llvm generates errors like:
<inline asm>:1:1: error: unknown directive
.syntax unified
I have verified it on clang 5, 6, 7, 8, 9, 10
as on native platform as for cross-compiling. This decision is
arguable, but it doesn't have impact on samples/bpf so it's easier
just ignore it for clang, at least for now...
Did you test ARCH=arm kernel builds with Clang with this series applied?
On Tue, Jul 27, 2021 at 10:53 AM Nick Desaulniers
[off-list ref] wrote:
On Tue, Jul 27, 2021 at 7:12 AM Pavo Banicevic
[off-list ref] wrote:
quoted
From: Ivan Khoronzhuk <redacted>
The samples/bpf with clang -emit-llvm reuses linux headers to build
bpf samples, and this w/a only for samples (samples/bpf/Makefile
CLANG-bpf).
It allows to build samples/bpf for arm bpf using clang.
In another way clang -emit-llvm generates errors like:
CLANG-bpf samples/bpf/tc_l2_redirect_kern.o
<inline asm>:1:2: error: invalid register/token name
rev16 r3, r0
This decision is arguable, probably there is another way, but
it doesn't have impact on samples/bpf, so it's easier just ignore
it for clang, at least for now.
NACK
The way to fix these is to sort out the header includes, not turning
off arbitrary things that are used by the actual kernel build for 32b
ARM.
Would it be too horrible to just get rid of `clang -emit-llvm` and use
vmlinux.h (we don't need to do CO-RE, btw, just generate vmlinux.h
from the matching kernel)? Kumar has already started moving in that
direction in his recent patch set ([0]). Would that get rid of all
these issues?
[0] https://patchwork.kernel.org/project/netdevbpf/list/?series=519281&state=*
From: Petr Vaněk <hidden> Date: 2021-07-28 13:53:39
On Tue, Jul 27, 2021 at 04:11:19PM +0200, Pavo Banicevic wrote:
From: Matt Redfearn <redacted>
Commit bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining
of some byteswap operations") added __always_inline to swab functions
and commit 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to
userspace headers") added a definition of __always_inline for use in
exported headers when the kernel's compiler.h is not available.
However, since swab.h does not include stddef.h, if the header soup does
not indirectly include it, the definition of __always_inline is missing,
resulting in a compilation failure, which was observed compiling the
perf tool using exported headers containing this commit:
In file included from /usr/include/linux/byteorder/little_endian.h:12:0,
from /usr/include/asm/byteorder.h:14,
from tools/include/uapi/linux/perf_event.h:20,
from perf.h:8,
from builtin-bench.c:18:
/usr/include/linux/swab.h:160:8: error: unknown type name `__always_inline'
static __always_inline __u16 __swab16p(const __u16 *p)
Fix this by replacing the inclusion of linux/compiler.h with
linux/stddef.h to ensure that we pick up that definition if required,
without relying on it's indirect inclusion. compiler.h is then included
indirectly, via stddef.h.
Fixes: 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to userspace headers")
Signed-off-by: Matt Redfearn <redacted>
---