Re: [PATCH v3] rtw88: Remove unnecessary check code
From: Kalle Valo <hidden>
Date: 2021-07-27 06:34:52
Also in:
linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2021-07-18 · [PATCH v3] rtw88: Remove unnecessary check code · Len Baker <hidden>
Len Baker [off-list ref] writes:
The rtw_pci_init_rx_ring function is only ever called with a fixed constant or RTK_MAX_RX_DESC_NUM for the "len" argument. Since this constant is defined as 512, the "if (len > TRX_BD_IDX_MASK)" check can never happen (TRX_BD_IDX_MASK is defined as GENMASK(11, 0) or in other words as 4095). So, remove this check. Signed-off-by: Len Baker <redacted>
Are everyone ok with this version? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches