Thread (9 messages) flat view 9 messages, 3 authors, 2021-07-27

Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry

From: asmadeus@codewreck.org
Date: 2021-07-27 00:00:26
Also in: lkml

Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700:
quoted
quoted
Yes, I did test it successfully. Aside from the commit messaged to be
reworded:
How's this?
===========================BEGIN========================================
9p/xen: Fix end of loop tests for list_for_each_entry

This patch addresses the following problems:
 - priv can never be NULL, so this part of the check is useless
 - if the loop ran through the whole list, priv->client is invalid and
it is more appropriate and sufficient to check for the end of
list_for_each_entry loop condition.

Signed-off-by: Harshvardhan Jha <redacted>
Will take the patch with this text as commit message later tonight

quoted
quoted
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
Thanks for the test!

-- 
Dominique
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help