Thread (13 messages) 13 messages, 3 authors, 2021-07-28

Re: [PATCH 0/3] can: fix same memory leaks in can drivers

From: Pavel Skripkin <hidden>
Date: 2021-07-26 17:29:45
Also in: linux-can, lkml

On Mon, 26 Jul 2021 18:29:38 +0300
Pavel Skripkin [off-list ref] wrote:
Hi, Marc and can drivers maintainers/reviewers!
I reread this I found out, that I missed logic here.

I mean:
A long time ago syzbot reported memory leak in mcba_usb can
driver[1]. It was using strange pattern for allocating coherent
buffers, which was leading to memory leaks.
I fixed this wrong pattern in mcba_usb driver and 
Yesterday I got a report,
that mcba_usb stopped working since my commit. I came up with quick
fix and all started working well.

There are at least 3 more drivers with this pattern, I decided to fix
leaks in them too, since code is actually the same (I guess, driver
authors just copy pasted code parts). Each of following patches is
combination of 91c02557174b ("can: mcba_usb: fix memory leak in
mcba_usb") and my yesterday fix [2].


Dear maintainers/reviewers, if You have one of these hardware pieces,
please, test these patches and report any errors you will find.

[1]
https://syzkaller.appspot.com/bug?id=c94c1c23e829d5ac97995d51219f0c5a0cd1fa54
[2]
https://lore.kernel.org/netdev/20210725103630.23864-1-paskripkin@gmail.com/ (local)


With regards,
Pavel Skripkin

Pavel Skripkin (3):
  can: usb_8dev: fix memory leak
  can: ems_usb: fix memory leak
  can: esd_usb2: fix memory leak

 drivers/net/can/usb/ems_usb.c  | 14 +++++++++++++-
 drivers/net/can/usb/esd_usb2.c | 16 +++++++++++++++-
 drivers/net/can/usb/usb_8dev.c | 15 +++++++++++++--
 3 files changed, 41 insertions(+), 4 deletions(-)


With regards,
Pavel Skripkin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help