Thread (3 messages) flat view 3 messages, 3 authors, 2021-07-26

Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set()

From: Leon Romanovsky <leon@kernel.org>
Date: 2021-07-25 10:10:56
Also in: linux-rdma, lkml

On Thu, Jul 22, 2021 at 05:58:16PM +0800, Jiapeng Chong wrote:
The return value is missing in this code scenario, add the return value
'0' to the return value 'err'.

Eliminate the follow smatch warning:

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083
mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'.

Reported-by: Abaci Robot <redacted>
Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes")
Signed-off-by: Jiapeng Chong <redacted>
---
Changes in v2:
  -For the follow advice: https://lore.kernel.org/patchwork/patch/1461601/

 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help