Re: [PATCH] Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()"

On Tue, 20 Jul 2021 17:27:39 +0800, Jia He wrote:

This reverts commit 2d2f5ded858a4f4659fc63e01dd55605598a8f05.

The hash looks wrong, the patch was applied to netdev/net AFAICT,
and the ref there is: 6206b7981a36 ("qed: fix possible unpaired
spin_{un}lock_bh in _qed_mcp_cmd_and_union()")

Please tag the subject with "net":

[PATCH net] Revert ...

That patch added additional spin_{un}lock_bh(), which was harmless
but pointless. The orginal code path has guaranteed the pair of
spin_{un}lock_bh().

We'd better revert it before we find the exact root cause of the
bug_on mentioned in that patch.

Cc: David S. Miller <davem@davemloft.net>
Cc: Prabhakar Kushwaha <redacted>
Signed-off-by: Jia He <redacted>

Please also add a Fixes tag.

Fixes: 6206b7981a36 ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()")