Re: [PATCH v2] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2021-07-20 10:23:47
Also in:
kvm, lkml
On Tue, Jul 20, 2021 at 03:13:37PM +0800, Xianting Tian wrote:
Add the missed virtio_device_ready() to set vsock frontend ready. Signed-off-by: Xianting Tian <redacted> --- net/vmw_vsock/virtio_transport.c | 2 ++ 1 file changed, 2 insertions(+)
Please include a changelog when you send v2, v3, etc patches.
quoted hunk ↗ jump to hunk
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index e0c2c992a..dc834b8fd 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c@@ -639,6 +639,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev) mutex_unlock(&the_virtio_vsock_mutex); + virtio_device_ready(vdev);
Why is this patch necessary?
The core virtio_dev_probe() code already calls virtio_device_ready for
us:
static int virtio_dev_probe(struct device *_d)
{
...
err = drv->probe(dev);
if (err)
goto err;
/* If probe didn't do it, mark device DRIVER_OK ourselves. */
if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
virtio_device_ready(dev); Attachments
- signature.asc [application/pgp-signature] 488 bytes