Re: [PATCH] SUNRPC: Convert from atomic_t to refcount_t on rpc_clnt->cl_count

On Sat, Jul 17, 2021 at 02:43:26PM +0000, Trond Myklebust wrote:

On Sat, 2021-07-17 at 18:18 +0800, Xiyu Yang wrote:

quoted

refcount_t type and corresponding API can protect refcounters from
accidental underflow and overflow and further use-after-free
situations.

Have you tested this patch? As far as I remember, the reason why we
never converted is that refcount_inc() gets upset and WARNs when you
bump a zero refcount, like we do very much on purpose in
rpc_free_auth(). Is that no longer the case?

It is still the case, they sent gazillion conversion patches with same
mistake.

Thanks

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com