Thread (2 messages) flat view 2 messages, 2 authors, 2021-07-16

Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-07-16 18:50:09
Also in: lkml

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 16 Jul 2021 10:02:18 +0300 you wrote:
As Alexander points out, when we are trying to recycle a cloned/expanded
SKB we might trigger a race.  The recycling code relies on the
pp_recycle bit to trigger,  which we carry over to cloned SKBs.
If that cloned SKB gets expanded or if we get references to the frags,
call skb_release_data() and overwrite skb->head, we are creating separate
instances accessing the same page frags.  Since the skb_release_data()
will first try to recycle the frags,  there's a potential race between
the original and cloned SKB, since both will have the pp_recycle bit set.

[...]
Here is the summary with links:
  - [1/1,v3] skbuff: Fix a potential race while recycling page_pool packets
    https://git.kernel.org/netdev/net/c/2cc3aeb5eccc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help