Thread (3 messages) flat view 3 messages, 3 authors, 2021-07-13

Re: [PATCH] net: fddi: fix UAF in fza_probe

From: "Maciej W. Rozycki" <macro@orcam.me.uk>
Date: 2021-07-13 16:59:58
Also in: lkml

On Tue, 13 Jul 2021, Pavel Skripkin wrote:
fp is netdev private data and it cannot be
used after free_netdev() call. Using fp after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() after error message.
 Can you justify the lines for a better layout?  The paragraph looks odd 
to me in its current form.
Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700
TURBOchannel adapter")
Signed-off-by: Pavel Skripkin <redacted>
 Otherwise LGTM.  And a good catch, thank you!

Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>

  Maciej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help