On 7/8/21 1:16 AM, Xiaoyao Li wrote:

Sorry I guess I didn't state it clearly during internal review.

I suggest something like this

if (ret != TDCALL_SUCCESS) {
     if (TDCALL_RETURN_CODE(ret) == TDCALL_INVALID_OPERAND)
         return -EINVAL;
     else if (TDCALL_RETURN_CODE(ret) == TDCALL_OPERAND_BUSY)
         return -EBUSY;
     else
         return -EFAULT; //I'm not sure if -EFAULT is proper.
}

As per current spec, TDCALL_INVALID_OPERAND, TDCALL_OPERAND_BUSY and
0 are the only possible return values. So I have checked for failure case
in if condition and returned success by default. Any reason for specifically
checking for success code ?

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer