Re: [PATCH net-next v3 1/3] selftests/ptr_ring: add benchmark application for ptr_ring

On Fri, Jul 02, 2021 at 04:17:17PM +0800, Yunsheng Lin wrote:

quoted

Let's reuse ptr_ring.c in tools/virtio/ringtest. Nothing virt specific there.

It *does* have some virtio specific at the end of ptr_ring.c.
It can be argued that the ptr_ring.c in tools/virtio/ringtest
could be refactored to remove the function related to virtio.

But as mentioned in the previous disscusion [1], the tools/virtio/
seems to have compile error in the latest kernel, it does not seems
right to reuse that.
And most of testcase in tools/virtio/ seems
better be in tools/virtio/ringtest instead，so until the testcase
in tools/virtio/ is compile-error-free and moved to tools/testing/
selftests/, it seems better not to reuse it for now.

That's a great reason to reuse - so tools/virtio/ stays working.
Please just fix that.

-- 
MST