Re: [PATCH net-next 2/6] sk_buff: track dst status in slow_gro
From: Paolo Abeni <pabeni@redhat.com>
Date: 2021-07-30 13:08:27
On Fri, 2021-07-30 at 04:08 -0700, Jakub Kicinski wrote:
On Wed, 28 Jul 2021 18:24:00 +0200 Paolo Abeni wrote:quoted
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 3ff18300d210..b1e5bbfcc926 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h@@ -992,6 +992,7 @@ static inline struct dst_entry *skb_dst(const struct sk_buff *skb) */ static inline void skb_dst_set(struct sk_buff *skb, struct dst_entry *dst) { + skb->slow_gro |= !!dst; skb->_skb_refdst = (unsigned long)dst; }@@ -1008,6 +1009,7 @@ static inline void skb_dst_set(struct sk_buff *skb, struct dst_entry *dst) static inline void skb_dst_set_noref(struct sk_buff *skb, struct dst_entry *dst) { WARN_ON(!rcu_read_lock_held() && !rcu_read_lock_bh_held()); + skb->slow_gro = !!dst;why is this one = and not |= ?
Mostly because I'm dumb. Sabrina Dubroca noted that already. I'll send a follow-up ASAP. Thanks! Paolo