Thread (3 messages) 3 messages, 3 authors, 2021-07-28

Re: [PATCH net] sctp: fix return value check in __sctp_rcv_asconf_lookup

From: Xin Long <lucien.xin@gmail.com>
Date: 2021-07-28 02:56:32
Also in: linux-sctp

On Tue, Jul 27, 2021 at 10:41 PM Marcelo Ricardo Leitner
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
As Ben Hutchings noticed, this check should have been inverted: the call
returns true in case of success.

Reported-by: Ben Hutchings <redacted>
Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
 net/sctp/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index eb3c2a34a31c64d5322f326613f4a4a02f8c902e..5ef86fdb11769d9c8a32219c5c7361fc34217b02 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -1203,7 +1203,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup(
        if (unlikely(!af))
                return NULL;

-       if (af->from_addr_param(&paddr, param, peer_port, 0))
+       if (!af->from_addr_param(&paddr, param, peer_port, 0))
                return NULL;

        return __sctp_lookup_association(net, laddr, &paddr, transportp);
--
2.31.1
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help