Re: [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2021-07-27 07:25:28
Also in:
oe-kbuild-all
On 7/26/2021 5:27 AM, Arnd Bergmann wrote:
quoted hunk ↗ jump to hunk
On Mon, Jul 26, 2021 at 12:29 PM kernel test robot [off-list ref] wrote:quoted
quoted
quoted
drivers/i2c/Kconfig:8:error: recursive dependency detected!drivers/i2c/Kconfig:8: symbol I2C is selected by IGB drivers/net/ethernet/intel/Kconfig:87: symbol IGB depends on PTP_1588_CLOCK drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by MLX4_EN drivers/net/ethernet/mellanox/mlx4/Kconfig:6: symbol MLX4_EN depends on NET_VENDOR_MELLANOX drivers/net/ethernet/mellanox/Kconfig:6: symbol NET_VENDOR_MELLANOX depends on I2C For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations"Sorry about this, the patch I was testing with has this additional hunk@@ -88,7 +88,7 @@ config IGB tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support" depends on PCI depends on PTP_1588_CLOCK || !PTP_1588_CLOCK - select I2C + depends on I2C select I2C_ALGOBIT help This driver supports Intel(R) 82575/82576 gigabit ethernet family ofthat I even describe in the changelog but forgot to include in the patch I sent. Arnd
With this hunk applied, everything looks good to me. Thanks for the fix! It would be nice if this sort of dependency had a keyword or some other slightly more intuitive way of handling it. We could make run-time IS_REACHABLE checks so that the functions which call into enable PTP support were disabled at run time in that case, I suppose as an alternative fix to this.... Acked-by: Jacob Keller <jacob.e.keller@intel.com>