Thread (37 messages) 37 messages, 6 authors, 2021-07-20

Re: [PATCH v4 net-next 10/15] net: bridge: switchdev object replay helpers for everybody

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-07-19 09:19:10
Also in: bridge

On Mon, Jul 19, 2021 at 12:44:29AM +0300, Vladimir Oltean wrote:
Note that:
(c) I do not expect a lot of functional change introduced for drivers in
    this patch, because:
    - nbp_vlan_init() is called _after_ netdev_master_upper_dev_link(),
      so br_vlan_replay() should not do anything for the new drivers on
      which we call it. The existing drivers where there was even a
      slight possibility for there to exist a VLAN on a bridge port
      before they join it are already guarded against this: mlxsw and
      prestera deny joining LAG interfaces that are members of a bridge.
    - br_fdb_replay() should now notify of local FDB entries, but I
      patched all drivers except DSA to ignore these new entries in
      commit 2c4eca3ef716 ("net: bridge: switchdev: include local flag
      in FDB notifications"). Driver authors can lift this restriction
      as they wish.
    - br_mdb_replay() should now fix the issue described in commit
      2c4eca3ef716 ("net: bridge: switchdev: include local flag in FDB
      notifications") for all drivers, I don't see any downside.
I really meant commit 4f2673b3a2b6 ("net: bridge: add helper to replay
port and host-joined mdb entries"), sorry for the copy-pasta mistake.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help