Re: [PATCH net 1/3] udp: check for encap using encap_enable

On Mon, 2021-07-12 at 13:32 +0100, Vadim Fedorenko wrote:

On 12.07.2021 09:37, Paolo Abeni wrote:

quoted

quoted

Fixes: 60fb9567bf30 ("udp: implement complete book-keeping for encap_needed")

IMHO this not fix. Which bug are you observing that is addressed here?

I thought that introduction of encap_enabled should go further to switch the
code to check this particular flag and leave encap_type as a description of
specific type (or subtype) of used encapsulation.

Than to me it looks more like a refactor than a fix. Is this strictly
needed by the following patch? if not, I suggest to consider net-next
as a target for this patch, or even better, drop it altogether. 

Cheers,

Paolo