Thread (2 messages) flat view 2 messages, 2 authors, 2021-06-16

Re: [PATCH] net: cdc_eem: fix tx fixup skb leak

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-16 15:05:49
Also in: linux-usb

On Wed, Jun 16, 2021 at 10:40:44PM +0800, Linyu Yuan wrote:
when usbnet transmit a skb, eem fixup it in eem_tx_fixup(),
if skb_copy_expand() failed, it return NULL,
usbnet_start_xmit() will have no chance to free original skb.

fix it by free orginal skb in eem_tx_fixup() first,
then check skb clone status, if failed, return NULL to usbnet.

Signed-off-by: Linyu Yuan <redacted>
---
 drivers/net/usb/cdc_eem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
What commit does this "Fix:"?  Can you please add that to the
signed-off-by area?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help