Thread (30 messages) 30 messages, 4 authors, 2021-06-21

Re: [PATCH net-next v5 03/15] virtio-net: add priv_flags IFF_NOT_USE_DMA_ADDR

flat view

From: Jason Wang <hidden>
Date: 2021-06-16 09:28:17
Also in: bpf, virtualization

在 2021/6/10 下午4:21, Xuan Zhuo 写道:
quoted hunk ↗ jump to hunk
virtio-net not use dma addr directly. So add this priv_flags
IFF_NOT_USE_DMA_ADDR.

Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
  drivers/net/virtio_net.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 0416a7e00914..6c1233f0ab3e 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3064,7 +3064,7 @@ static int virtnet_probe(struct virtio_device *vdev)
  
  	/* Set up network device as normal. */
  	dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE |
-			   IFF_TX_SKB_NO_LINEAR;
+			   IFF_TX_SKB_NO_LINEAR | IFF_NOT_USE_DMA_ADDR;

I wonder instead of doing trick like this, how about teach the virtio core to accept DMA address via sg?

Thanks

  	dev->netdev_ops = &virtnet_netdev;
  	dev->features = NETIF_F_HIGHDMA;
  
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help