Thread (71 messages) 71 messages, 8 authors, 2021-08-16

Re: [PATCH bpf-next 2/3] net: bonding: Use per-cpu rr_tx_counter

From: Jussi Maki <hidden>
Date: 2021-06-14 07:55:54
Also in: bpf

On Thu, Jun 10, 2021 at 2:04 AM Jay Vosburgh [off-list ref] wrote:
Jussi Maki [off-list ref] wrote:

        With the rr_tx_counter is per-cpu, each CPU is essentially doing
its own round-robin logic, independently of other CPUs, so the resulting
spread of transmitted packets may not be as evenly distributed (as
multiple CPUs could select the same interface to transmit on
approximately in lock-step).  I'm not sure if this could cause actual
problems in practice, though, as particular flows shouldn't skip between
CPUs (and thus rr_tx_counters) very often, and round-robin already
shouldn't be the first choice if no packet reordering is a hard
requirement.

        I think this patch could be submitted against net-next
independently of the rest of the series.
Yes this makes sense. I'll submit it separately against net-next today
and drop it off from this patchset.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help