Re: [Intel-wired-lan] [PATCH] igc: change default return of igc_read_phy_reg()
From: Fuxbrumer, Dvora <hidden>
Date: 2021-06-24 19:58:50
Also in:
intel-wired-lan, lkml
On 5/21/2021 22:50, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com>
Static analysis reports this problem
igc_main.c:4944:20: warning: The left operand of '&'
is a garbage value
if (!(phy_data & SR_1000T_REMOTE_RX_STATUS) &&
~~~~~~~~ ^
pyy_data is set by the call to igc_read_phy_reg() only if
there is a read_reg() op, else it is unset and a 0 is
returned. Change the return to -EOPNOTSUPP.
Fixes: 208983f099d9 ("igc: Add watchdog")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/intel/igc/igc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Tested-by: Dvora Fuxbrumer <redacted>