Re: [PATCH] vringh: Use wiov->used to check for read/write desc order
From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2021-06-23 16:10:37
Also in:
lkml, virtualization
On Tue, Jun 22, 2021 at 05:07:53PM +0530, Neeraj Upadhyay wrote:
As iov->used is incremented when descriptors are processed in __vringh_iov(), use it to check for incorrect read and write descriptor order. Signed-off-by: Neeraj Upadhyay <redacted> --- drivers/vhost/vringh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
quoted hunk ↗ jump to hunk
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c index 4af8fa2..14e2043 100644 --- a/drivers/vhost/vringh.c +++ b/drivers/vhost/vringh.c@@ -359,7 +359,7 @@ __vringh_iov(struct vringh *vrh, u16 i,iov = wiov; else { iov = riov; - if (unlikely(wiov && wiov->i)) { + if (unlikely(wiov && wiov->used)) { vringh_bad("Readable desc %p after writable", &descs[i]); err = -EINVAL; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation