Thread (4 messages) flat view 4 messages, 3 authors, 2021-06-23

Re: [PATCH] decnet: af_decnet: pmc should not be referenced when it's NULL

From: Eric Dumazet <hidden>
Date: 2021-06-23 10:47:56
Also in: lkml


On 6/23/21 5:35 AM, 13145886936@163.com wrote:
quoted hunk ↗ jump to hunk
From: gushengxian <redacted>

pmc should not be referenced when it's NULL.

Signed-off-by: gushengxian <redacted>
---
 net/decnet/af_decnet.c | 67 ++++++++++++++++--------------------------
 1 file changed, 25 insertions(+), 42 deletions(-)
diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
index 5dbd45dc35ad..be2758ac40cb 100644
--- a/net/decnet/af_decnet.c
+++ b/net/decnet/af_decnet.c
@@ -152,7 +152,8 @@ static atomic_long_t decnet_memory_allocated;
 
 static int __dn_setsockopt(struct socket *sock, int level, int optname,
 		sockptr_t optval, unsigned int optlen, int flags);
-static int __dn_getsockopt(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen, int flags);
+static int __dn_getsockopt(struct socket *sock, int level, int optname,
+		char __user *optval, int __user *optlen, int flags);
 
 static struct hlist_head *dn_find_list(struct sock *sk)
 {
@@ -176,6 +177,7 @@ static int check_port(__le16 port)
 
 	sk_for_each(sk, &dn_sk_hash[le16_to_cpu(port) & DN_SK_HASH_MASK]) {
 		struct dn_scp *scp = DN_SK(sk);
+
 		if (scp->addrloc == port)
 			return -1;
Please do not add noise to your patch.

Never mix cleanups and a fix.

Also, decnet is no longer used, please do not send space cleanups.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help