Re: [Intel-wired-lan] [PATCH] e1000e: Fix an error handling path in 'e1000_probe()'
flat view
From: Neftin, Sasha <hidden>
Date: 2021-06-22 08:31:55
Also in:
intel-wired-lan, kernel-janitors, lkml
On 6/16/2021 08:05, Christophe JAILLET wrote:
quoted hunk ↗ jump to hunk
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET <redacted> --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 5435606149b0..c8aa69fd0405 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c@@ -7662,6 +7662,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma:
Acked-by: Sasha Neftin <redacted>