Thread (5 messages) flat view 5 messages, 2 authors, 2021-06-18

Re: [PATCH 1/4] net: ll_temac: Make sure to free skb when it is completely used

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:20:11
Also in: linux-arm-kernel, lkml, stable

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 18 Jun 2021 12:52:23 +0200 you wrote:
With the skb pointer piggy-backed on the TX BD, we have a simple and
efficient way to free the skb buffer when the frame has been transmitted.
But in order to avoid freeing the skb while there are still fragments from
the skb in use, we need to piggy-back on the TX BD of the skb, not the
first.

Without this, we are doing use-after-free on the DMA side, when the first
BD of a multi TX BD packet is seen as completed in xmit_done, and the
remaining BDs are still being processed.

[...]
Here is the summary with links:
  - [1/4] net: ll_temac: Make sure to free skb when it is completely used
    https://git.kernel.org/netdev/net/c/6aa32217a9a4
  - [2/4] net: ll_temac: Add memory-barriers for TX BD access
    https://git.kernel.org/netdev/net/c/28d9fab458b1
  - [3/4] net: ll_temac: Fix TX BD buffer overwrite
    https://git.kernel.org/netdev/net/c/c364df2489b8
  - [4/4] net: ll_temac: Avoid ndo_start_xmit returning NETDEV_TX_BUSY
    https://git.kernel.org/netdev/net/c/f63963411942

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help