Thread (9 messages) flat view 9 messages, 2 authors, 2021-06-18

Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue

From: lipeng (Y) <hidden>
Date: 2021-06-18 00:45:29
Also in: lkml

在 2021/6/18 0:29, Andrew Lunn 写道:
quoted
@@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d)
  static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd)
  {
  	/* struct z8530_dev *sv11=dev_to_sv(d);
-	   z8530_ioctl(d,&sv11->chanA,ifr,cmd) */
+	 * z8530_ioctl(d,&sv11->chanA,ifr,cmd)
+	 */
  	return hdlc_ioctl(d, ifr, cmd);
  }
That looks more like dead code than anything else. I would suggest you
do a git blame to see if there is anything interesting about this, and
if not, remove it.

    Andrew
.
Hi,  Andrew

It's  dead code,  will remove it.

Thanks for your advice.

         Peng Li


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help