Thread (13 messages) flat view 13 messages, 3 authors, 2021-06-17

Re: [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-06-16 16:23:24
Also in: lkml

On Wed, Jun 16, 2021 at 05:33:56PM +0800, Guangbin Huang wrote:
quoted hunk ↗ jump to hunk
From: Peng Li <redacted>

According to the chackpatch.pl,
no spaces is necessary at the start of a line.

Signed-off-by: Peng Li <redacted>
Signed-off-by: Guangbin Huang <redacted>
---
 drivers/net/wan/hdlc_ppp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index 7b7c02d..53c668e 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -34,8 +34,8 @@
 
 enum {IDX_LCP = 0, IDX_IPCP, IDX_IPV6CP, IDX_COUNT};
 enum {CP_CONF_REQ = 1, CP_CONF_ACK, CP_CONF_NAK, CP_CONF_REJ, CP_TERM_REQ,
-      CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
-      LCP_DISC_REQ, CP_CODES};
+	CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
+	LCP_DISC_REQ, CP_CODES};
Do you think this looks better or worse after the change?

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help